Help...?

[Moonlight]

Anyway, I have a navigation system, and it gives me this error:

Parse error: syntax error, unexpected T_STRING, expecting ',' or ';' in /home/a1728691/public_html/includes/functions.php on line 21

The php code to show it is:

<?php navigation(); ?>

And the function [This is part of a "bigger" part of coding, thus there is no <?php and ?> tags as they come earlier/later on.]:

function navigation()
{
    if( is_logged_in() ){
        echo '<a href='index.php'>Home</a><br />';
        echo '<a href='news.php'>News</a><br />';
        echo '<a href='logout.php'>Logout</a><br />';    
    } else {
        echo '<a href='index.php'>Home</a><br />';
        echo '<a href='login.php'>Login</a><br />';
        echo '<a href='signup.php'>Signup</a><br />';   
        echo '<a href='news.php'>News</a><br />';
    }
} 

[Avalanche]

It may be possible using the single quotes in the link as well as in the echo is messing something up.

function navigation() 
{ 
    if( is_logged_in() ){ 
        echo '<a href="index.php">Home</a><br />'; 
        echo '<a href="news.php">News</a><br />'; 
        echo '<a href="logout.php">Logout</a><br />';     
    } else { 
        echo '<a href="index.php">Home</a><br />'; 
        echo '<a href="login.php">Login</a><br />'; 
        echo '<a href="signup.php">Signup</a><br />';    
        echo '<a href="news.php">News</a><br />'; 
    } 
} 

Try using the double quotes instead? It won't mess up the HTML. Notice how using the double quotes changes the color of the links. I'm pretty sure that's what is causing your error.

[Noma]

@Avalanche's solution should solve the problem. The reason the links are changing color is your quotes are excluding the links from the original quotations, making them just part of the code and not part of the link reference.

[Avalanche]

@Noma - yeah that's the more official way of saying it. XD But then when PHP doesn't detect a ';' or ',' after it thinks the echo statement has ended it sends and error.

[Noma]

I wasn't correcting you, just agreeing =]

[Moonlight]

Thank you! It works.

[Avalanche]

@Noma Oh yeah I know, no worries XD

@Moonlight YAY!

[jibbles]

An alternative solution is to escape the single quotes. By putting a backslash before the quote mark it tells php that this isn't the end of the string. The backslash itself won't be echo'd.

function navigation()
{
    if( is_logged_in() ){
        echo '<a href=\'index.php\'>Home</a><br />';
        echo '<a href=\'news.php\'>News</a><br />';
        echo '<a href=\'logout.php\'>Logout</a><br />';    
    } else {
        echo '<a href=\'index.php\'>Home</a><br />';
        echo '<a href=\'login.php\'>Login</a><br />';
        echo '<a href=\'signup.php\'>Signup</a><br />';   
        echo '<a href=\'news.php\'>News</a><br />';
    }
}